Conversation
…e. Also added an option to turn it off in prefrences.
|
@magsjoq Cool! But translations are submitted via Transifex so you should not include the Italian and Swedish one in this pull request. Please, only define English in development :-) |
|
Hi @magsjoq . I think this is your first contribution, isn't it? Before we can accept the PR we need you sign the contributor agreement in https://owncloud.org/contribute/agreement/ and send it to @karlitschek . The code seems OK, but I don't think we need an option to allow the user disable/enable the 'memory' of the location. @jancborchardt , what do you think about this? |
|
This should not be a setting, but work automatically. The last location you browsed to should always be remembered. |
|
So thank you very much @magsjoq! We can improve this even more though. :) |
|
@davivel @jabarros Removed the setting (so it now works automatically) and the translation strings. The agreement has already been handle by @karlitschek . |
|
Thanks, @magsjoq . The code seems fine. We'll try to push this to be validated by QA. |
|
@magsjoq btw, join us on IRC in #owncloud-android! :) |
|
Hi, @magsjoq . We fixed this on our side. We'll take your changes in other branch and create a new PR to replace this one. |
|
Replaced by #700. |
Fixes issue #594.
Adds an option to choose if you want to remember the last upload location from share. If the user wants to remember the last upload location, the path is stored in the shared preferences and the upload activity will start in that path. If the path no longer exists the activity will start in the parent folder. Also added an actionbar to upload activity containing the name of the current folder.
Provides strings in English, Italian and Swedish.