Skip to content

Remember last share location#660

Closed
magsjoq wants to merge 9 commits intoowncloud:developfrom
owncloudChalmers:remember_last_share_location
Closed

Remember last share location#660
magsjoq wants to merge 9 commits intoowncloud:developfrom
owncloudChalmers:remember_last_share_location

Conversation

@magsjoq
Copy link
Copy Markdown
Contributor

@magsjoq magsjoq commented Oct 17, 2014

Fixes issue #594.

Adds an option to choose if you want to remember the last upload location from share. If the user wants to remember the last upload location, the path is stored in the shared preferences and the upload activity will start in that path. If the path no longer exists the activity will start in the parent folder. Also added an actionbar to upload activity containing the name of the current folder.

Provides strings in English, Italian and Swedish.

@jabarros
Copy link
Copy Markdown
Contributor

@magsjoq Cool! But translations are submitted via Transifex so you should not include the Italian and Swedish one in this pull request. Please, only define English in development :-)

@davivel
Copy link
Copy Markdown
Contributor

davivel commented Oct 21, 2014

Hi @magsjoq . I think this is your first contribution, isn't it? Before we can accept the PR we need you sign the contributor agreement in https://owncloud.org/contribute/agreement/ and send it to @karlitschek .

The code seems OK, but I don't think we need an option to allow the user disable/enable the 'memory' of the location. @jancborchardt , what do you think about this?

@jancborchardt
Copy link
Copy Markdown
Member

This should not be a setting, but work automatically. The last location you browsed to should always be remembered.

@jancborchardt
Copy link
Copy Markdown
Member

So thank you very much @magsjoq! We can improve this even more though. :)

@magsjoq
Copy link
Copy Markdown
Contributor Author

magsjoq commented Oct 21, 2014

@davivel @jabarros Removed the setting (so it now works automatically) and the translation strings.

The agreement has already been handle by @karlitschek .

@davivel
Copy link
Copy Markdown
Contributor

davivel commented Oct 22, 2014

Thanks, @magsjoq . The code seems fine. We'll try to push this to be validated by QA.

@jancborchardt
Copy link
Copy Markdown
Member

@magsjoq btw, join us on IRC in #owncloud-android! :)

@jabarros
Copy link
Copy Markdown
Contributor

Hi @magsjoq

We are involved in the validation of your PR and we have found the bug #690 related to when we have more than one account, and we try to share a file, a crash appears.

If it is possible, could you take a look to it?

@davivel
Copy link
Copy Markdown
Contributor

davivel commented Oct 31, 2014

Hi, @magsjoq . We fixed this on our side. We'll take your changes in other branch and create a new PR to replace this one.

@davivel
Copy link
Copy Markdown
Contributor

davivel commented Oct 31, 2014

Replaced by #700.

@davivel davivel closed this Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants